Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove Chris Dickinson from active releasers #11011

Merged
merged 1 commit into from
Jan 28, 2017
Merged

doc: remove Chris Dickinson from active releasers #11011

merged 1 commit into from
Jan 28, 2017

Conversation

bnoordhuis
Copy link
Member

The last release Chris did was v1.8.1 from April 2015.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. lts-watch-v6.x labels Jan 26, 2017
@mscdex mscdex added the meta Issues and PRs related to the general management of the project. label Jan 26, 2017
Trott
Trott approved these changes Jan 26, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Easy enough to put him back if he starts doing releases again.

ChALkeR
ChALkeR approved these changes Jan 26, 2017
View reviewed changes
Copy link
Member

@ChALkeR ChALkeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Perhaps it's also the time to remove «and io.js» from the line above =).

mhdawson
mhdawson approved these changes Jan 27, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnoordhuis
doc: remove Chris Dickinson from active releasers
56f4f09 
The last release Chris did was v1.8.1 from April 2015.

PR-URL: nodejs#11011
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@bnoordhuis bnoordhuis closed this Jan 28, 2017
@bnoordhuis bnoordhuis deleted the update-releasers branch January 28, 2017 11:33
@bnoordhuis bnoordhuis merged commit 56f4f09 into nodejs:master Jan 28, 2017
@bnoordhuis
Copy link
Member Author

Thanks, landed in 56f4f09.

Perhaps it's also the time to remove «and io.js» from the line above =)

I noticed that but I decided to leave it in because it's correct in that io.js releases were signed with one of the listed keys. Perhaps the tense should be "are" or "will have been" instead of "will be."

@ChALkeR
Copy link
Member

ChALkeR commented Jan 28, 2017 •
edited
Loading

Perhaps the tense should be "are" or "will have been" instead of "will be."

That contradicts with «active releasers» and removing Chris from that list, then.

Perhaps:

  • «Releases of Node.js and io.js will be signed with one of the following GPG keys» → «Releases of Node.js will be signed with one of the following GPG keys»
  • «Previous releases of Node.js have been signed with one of the following GPG keys» → «Previous releases of Node.js and io.js have been signed with one of the following GPG keys»

@bnoordhuis
Copy link
Member Author

That contradicts with «active releasers» and removing Chris from that list, then.

The README itself doesn't mention "active releasers" anywhere. I've filed #11054 to reword and remove the "and io.js" part.

evanlucas pushed a commit that referenced this pull request Jan 31, 2017
@bnoordhuis @evanlucas
doc: remove Chris Dickinson from active releasers
0bf3b24 
The last release Chris did was v1.8.1 from April 2015.

PR-URL: #11011
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 31, 2017
Merged
jasnell pushed a commit that referenced this pull request Mar 8, 2017
@bnoordhuis @jasnell
doc: remove Chris Dickinson from active releasers
b5985f4 
The last release Chris did was v1.8.1 from April 2015.

PR-URL: #11011
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 8, 2017
@bnoordhuis @jasnell
doc: remove Chris Dickinson from active releasers
66d6ee7 
The last release Chris did was v1.8.1 from April 2015.

PR-URL: #11011
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@bnoordhuis @MylesBorins
doc: remove Chris Dickinson from active releasers
ff9a86a 
The last release Chris did was v1.8.1 from April 2015.

PR-URL: #11011
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@bnoordhuis @MylesBorins
doc: remove Chris Dickinson from active releasers
fc2bb2c 
The last release Chris did was v1.8.1 from April 2015.

PR-URL: #11011
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@Trott Trott Trott approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@evanlucas evanlucas evanlucas approved these changes

@jasnell jasnell jasnell approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.