v7.x: backport a few WHATWG URL changes #11069
Conversation
nodejs-github-bot
added
dont-land-on-v4.x
url
|
LGTM |
italoacasas
force-pushed
the
v7.x-staging
branch
from
376b9a4
to
506a50b
Compare
|
@TimothyGu Have you rebased and force pushed? There are a lot of previous commits in this PR now. EDIT: or is this the CI's doing? |
|
@joyeecheung I believe someone force-pushed to v7.x-staging which led to this problem. Indeed, IRC #node-dev shows: |
|
Sorry that this happens @TimothyGu, I had the need to drop a commit from staging. |
|
btw my understanding of backporting |
|
@italoacasas, sorry I'm not super familiar with this topic. So if there are no conflicts and the PR is not labelled dont-land-on-v7.x, landing of these commits is automatic? |
|
@TimothyGu, unfortunately, is not automatic, normally someone from the release team should cherry-pick the commit to the |
PR-URL: nodejs#10955 Fixes: nodejs#10800 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs#10906 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Even though this is not fully Web IDL spec-compliant, it is arguably the best we can do. Following the spec would mean non-trivial performance deterioration (10% when parsing a medium-length URL), while the current getter behavior is not adopted by any implementer, and it causes some spec ambiguity when the getter is called with !(this instanceof URL). This commit adopts Chrome's behavior, and is consistent with ECMAScript-defined classes while providing reasonable behaviors for corner cases as well. Until the Web IDL spec is changed one way or another, this is the way to go. PR-URL: nodejs#10906 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
TimothyGu
force-pushed
the
v7.x-staging
branch
from
c950253
to
b94eec1
Compare
|
So if I understand correctly, no backport has been requested from @nodejs/release to @TimothyGu (and this applies cleanly)? Anyway I think the release team should be notified, just to be safe. |
These commits are from #10955 and #10906 unchanged. Since the WHATWG URL API is still in Stage: 1 Experimental, the removal of
url.originFor()and ofinspect()should not be a problem.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
url