Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: refactor of CopyProperties with V8 5.5 DefineProperty #11102

Closed
wants to merge 1 commit into from
Closed

src: refactor of CopyProperties with V8 5.5 DefineProperty #11102

wants to merge 1 commit into from

Commits on Feb 4, 2017

  1. src: refactor CopyProperties to remove JS 

    CopyProperties() is refactored to use
the V8 5.5 DefineProperty() API call.
The change does not alter current behaviour.
It is a step prior to removing the function
CopyProperties, which becomes reduntant
after fixes of V8 SetNamedPropertyHandler
in 5.5. V8.

Strings used as property attributes
(value, enumerable etc) and accessors
are defined as persistent strings
in src/env.h
    @AnnaMag
    AnnaMag committed Feb 4, 2017
    Configuration menu
    Copy the full SHA
    9cb6174 View commit details
    Browse the repository at this point in the history