Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: stricter argument checking in toString #11120

Merged
merged 4 commits into from
Feb 5, 2017
Merged

buffer: stricter argument checking in toString #11120

merged 4 commits into from
Feb 5, 2017

Commits on Feb 2, 2017

  1. buffer: stricter argument checking in toString 

    This prevents the confusing behavior of `buf.toString(0, 5)` by
disallowing passing `0` as the encoding.
    @seishun
    seishun committed Feb 2, 2017
    Configuration menu
    Copy the full SHA
    4c453db View commit details
    Browse the repository at this point in the history

  2. add test

    @seishun
    seishun committed Feb 2, 2017
    Configuration menu
    Copy the full SHA
    0635c4a View commit details
    Browse the repository at this point in the history

  3. add test for null, check for full error

    @seishun
    seishun committed Feb 2, 2017
    Configuration menu
    Copy the full SHA
    2108299 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2017

  1. fix lint

    @seishun
    seishun committed Feb 3, 2017
    Configuration menu
    Copy the full SHA
    d96ed87 View commit details
    Browse the repository at this point in the history