Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: increase coverage of buffer #11122

Closed
wants to merge 1 commit into from
Closed

test: increase coverage of buffer #11122

wants to merge 1 commit into from

Conversation

DavidCai1111
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 2, 2017
@hiroppy hiroppy added the buffer Issues and PRs related to the buffer subsystem. label Feb 2, 2017
joyeecheung
joyeecheung approved these changes Feb 2, 2017
View reviewed changes
test/parallel/test-buffer-write-noassert.js Outdated
() => Buffer.alloc(9)[funx].apply(new Uint32Array(1), args),
new RegExp('^TypeError: (?:"buffer" )?argument (must|should) be ' +
'a Buffer(?: or Uint8Array)?$')
);
Copy link
Member

@joyeecheung joyeecheung Feb 2, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like

const error = /Int/.test(funx) ?
  /^TypeError: "buffer" argument must be a Buffer or Uint8Array$/ :
  /^TypeError: argument should be a Buffer$/;

assert.throws(
  () => Buffer.alloc(9)[funx].apply(new Uint32Array(1), args),
  error
);

would probably be easier to read.

jasnell
jasnell approved these changes Feb 2, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @joyeecheung's formatting suggestion

@DavidCai1111
Copy link
Member Author

OK, updated.

@italoacasas
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/6181/console

jasnell pushed a commit that referenced this pull request Feb 6, 2017
@DavidCai1111 @jasnell
test: increase coverage of buffer
901cb8c 
PR-URL: #11122
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@jasnell
Copy link
Member

jasnell commented Feb 6, 2017

Landed in 901cb8c

@jasnell jasnell closed this Feb 6, 2017
@italoacasas
Copy link
Contributor

This is failing in v7.x, maybe because of some semver-major in buffer. Any plan to backport this?

@joyeecheung
Copy link
Member

joyeecheung commented Feb 9, 2017 •
edited
Loading

This depends on semver-major #10236 which adds support for Uint8Array input to buffer methods. Should be manually backportable though. @DavidCai1993 mind submitting a backport for this?

@DavidCai1111
Copy link
Member Author

OK

@DavidCai1111 DavidCai1111 mentioned this pull request Feb 11, 2017
Closed
3 tasks
italoacasas pushed a commit that referenced this pull request Feb 16, 2017
@DavidCai1111 @italoacasas
test: increase coverage of buffer
f542c59 
PR-URL: #11312
Backport-of: #11122
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
italoacasas pushed a commit that referenced this pull request Feb 22, 2017
@DavidCai1111 @italoacasas
test: increase coverage of buffer
66081d1 
PR-URL: #11312
Backport-of: #11122
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
@DavidCai1111 @krydos
test: increase coverage of buffer
54e2f1e 
PR-URL: nodejs#11122
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@jasnell jasnell mentioned this pull request Apr 4, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@gibfahn
Copy link
Member

gibfahn commented Jun 17, 2017

Adding dont-land-on-v6.x due to #11312 (comment), @DavidCai1993 if you think this should be backported please raise a PR (see the backporting guide for the howto.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@italoacasas italoacasas italoacasas approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@hiroppy hiroppy hiroppy approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@DavidCai1111 @italoacasas @jasnell @joyeecheung @gibfahn @thefourtheye @hiroppy @nodejs-github-bot