Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: support UTF-8 in compiled-in JS source files #11129

Merged
merged 2 commits into from
Feb 13, 2017
Merged

src: support UTF-8 in compiled-in JS source files #11129

merged 2 commits into from
Feb 13, 2017

Commits on Feb 13, 2017

  1. src: support UTF-8 in compiled-in JS source files 

    Detect it when source files in lib/ are not ASCII.  Decode them as UTF-8
and store them as UTF-16 in the binary so they can be used as external
string resources without non-ASCII characters getting mangled.

Fixes: nodejs#10673
PR-URL: nodejs#11129
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @bnoordhuis
    bnoordhuis committed Feb 13, 2017
    4 Configuration menu
    Copy the full SHA
    c30fc8d View commit details
    Browse the repository at this point in the history

  2. lib: replace \u2019 with regular ascii quote 

    The previous commit stores baked-in files with non-ASCII characters
as UTF-16.  Replace the \u2019 with a regular quote character so that
the files they're in can be stored as one-byte strings.  The UTF-16
functionality is still tested by the Unicode diagram in lib/timers.js.

PR-URL: nodejs#11129
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @bnoordhuis
    bnoordhuis committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    fd8587e View commit details
    Browse the repository at this point in the history