Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: add a check for byteLength in readIntBE() and readIntLE() #11146

Closed
wants to merge 3 commits into from
Closed

buffer: add a check for byteLength in readIntBE() and readIntLE() #11146

wants to merge 3 commits into from

Commits on Jan 5, 2018

  1. buffer: check byteLength in readIntBE() and readIntLE() 

    The 'byteLength' argument should be required and of type 'number'. It should have a value between 1 and 6.
This is a fix for issue: nodejs#10515
    @seppevs @Trott
    seppevs authored and Trott committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    f558b00 View commit details
    Browse the repository at this point in the history

  2. benchmark: improve buffer.readIntLE()/readIntBE() benchmarks 

    Split them into their own benhmark file and use different byteLength
values.
    @Trott
    Trott committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    bac64ba View commit details
    Browse the repository at this point in the history

  3. buffer: check byteLength in readIntBE() and readIntLE()

    @Trott
    Trott committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    710d1dc View commit details
    Browse the repository at this point in the history