-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: fix building --without-v8-platform (backport v7.x) #11157
src: fix building --without-v8-platform (backport v7.x) #11157
Conversation
The call signature of v8_platform.StartInspector needs to be the same whether or not NODE_USE_V8_PLATFORM, otherwise Node will fail to compile if HAVE_INSPECTOR and !NODE_USE_V8_PLATFORM. (cherry picked from commit e619725)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @mykmelez some test are failing here. |
@italoacasas If you click through, you'll see that the buildbots are green. The CI is somehow misreporting their status. |
The OSX build bot did fail. It's been failing for a couple of days now. When clicking through, it shows the green result from the last successful run. |
Right, I see
Indeed, the Mac build reports a java.lang.NullPointerException at java.util.HashSet.(HashSet.java:118) both for this PR's build and for previous ones (f.e. the previous build https://ci.nodejs.org/job/node-test-commit-osx/7642/). So that's an issue with the CI service, not this PR. Erm, I'm unsure of next steps here (first time Node.js bug fixer). I don't see issues on the CI service itself in this repository's issue tracker. Is there another place I should file those? |
The call signature of v8_platform.StartInspector needs to be the same whether or not NODE_USE_V8_PLATFORM, otherwise Node will fail to compile if HAVE_INSPECTOR and !NODE_USE_V8_PLATFORM. (cherry picked from commit e619725) PR-URL: nodejs#11157 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
should this also land in v6? |
No, this fix is for a regression in #9691, which landed in v7, so v6 is unaffected. |
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
src
Backport of the relevant commit from #11088 to v7.x-staging.
The call signature of v8_platform.StartInspector needs to be the same
whether or not NODE_USE_V8_PLATFORM, otherwise Node will fail to compile
if HAVE_INSPECTOR and !NODE_USE_V8_PLATFORM.
(cherry picked from commit e619725)