-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
child_process: increase default maxBuffer to 1024*1024 bytes #11196
child_process: increase default maxBuffer to 1024*1024 bytes #11196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm +0 on the change... but if this passes in CI then I'm shocked that there is no test!
@cjihrig @trevnorris ... PTAL |
There are a few other places in the documentation that need to be updated. I don't really have an opinion on whether this needs to be done or not, but the changes LGTM. |
the commit message will need to conform to standards, and could you include information in the referenced issue in the git commit message body? also, it should be possible to detect when the process is attempting to write more than |
@trevnorris I will change the commit message. |
Ping on this. |
0947cf0
to
9d9af5a
Compare
Increase the default maxBuffer for child_process.exec from 200 * 1024 bytes to 1024 KB so child processes don't get terminated too soon. This is a fix for nodejs#9829
9d9af5a
to
fefd78a
Compare
Closing due to inactivity. |
child_process: increase default maxBuffer to 1024*1024
Increase the default
maxBuffer
forchild_process.exec
from 200 * 1024 bytes to 1024 KB.This is a fix for #9829
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
child_process