Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve checks in test-path-parse-format #11223

Merged
merged 1 commit into from
Feb 9, 2017
Merged

test: improve checks in test-path-parse-format #11223

merged 1 commit into from
Feb 9, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 7, 2017

  • validate full error messages
  • use assert.throws() instead of try...catch
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 7, 2017
@mscdex mscdex added the path Issues and PRs related to the path subsystem. label Feb 7, 2017
@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 9, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6303/

@cjihrig
test: improve checks in test-path-parse-format
0700927 
- validate full error messages
- use assert.throws() instead of try...catch

PR-URL: nodejs#11223
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@cjihrig cjihrig merged commit 0700927 into nodejs:master Feb 9, 2017
@cjihrig cjihrig deleted the path-test branch February 9, 2017 18:30
italoacasas pushed a commit that referenced this pull request Feb 13, 2017
@cjihrig @italoacasas
test: improve checks in test-path-parse-format
3d190bb 
- validate full error messages
- use assert.throws() instead of try...catch

PR-URL: #11223
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@italoacasas italoacasas mentioned this pull request Feb 13, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
@cjihrig @italoacasas
test: improve checks in test-path-parse-format
25226ce 
- validate full error messages
- use assert.throws() instead of try...catch

PR-URL: nodejs#11223
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
@cjihrig @krydos
test: improve checks in test-path-parse-format
73adab4 
- validate full error messages
- use assert.throws() instead of try...catch

PR-URL: nodejs#11223
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@jasnell
Copy link
Member

jasnell commented Mar 7, 2017

Would require a backport PR to land in v4

jasnell pushed a commit that referenced this pull request Mar 7, 2017
@cjihrig @jasnell
test: improve checks in test-path-parse-format
1366b64 
- validate full error messages
- use assert.throws() instead of try...catch

PR-URL: #11223
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@cjihrig @MylesBorins
test: improve checks in test-path-parse-format
7aebc69 
- validate full error messages
- use assert.throws() instead of try...catch

PR-URL: #11223
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@evanlucas evanlucas evanlucas approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
path Issues and PRs related to the path subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @jasnell @evanlucas @joyeecheung @mscdex @nodejs-github-bot