Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

querystring: fix empty pairs handling #11234

Closed
wants to merge 2 commits into from
Closed

querystring: fix empty pairs handling #11234

wants to merge 2 commits into from

Commits on Feb 8, 2017

  1. querystring: fix empty pairs and optimize parse() 

    This commit fixes handling of empty pairs that occur before the end
of the query string so that they are also ignored.

Additionally, some optimizations have been made, including:

* Avoid unnecessary code execution where possible
* Use a lookup table when checking for hex characters
* Avoid forced decoding when '+' characters are encountered and we
are using the default decoder

Fixes: nodejs#10454
    @mscdex
    mscdex committed Feb 8, 2017
    Configuration menu
    Copy the full SHA
    851c419 View commit details
    Browse the repository at this point in the history

  2. test: improve querystring.parse assertion messages

    @mscdex
    mscdex committed Feb 8, 2017
    Configuration menu
    Copy the full SHA
    7b72507 View commit details
    Browse the repository at this point in the history