build: don't rebuild test/gc add-on unnecessarily #11311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
jasnell
approved these changes
Feb 11, 2017
thefourtheye
approved these changes
Feb 12, 2017
Remove the explicit dependency on $(NODE_EXE), it always triggers a rebuild due to it being a .PHONY rule. Add-ons in test/addons/ have the same implicit dependency so it isn't completely without precedent. PR-URL: nodejs#11311 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
bnoordhuis
force-pushed
the
tweak-gc-addon-rule
branch
from
308ea5c to
b7ac0b2
Compare
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 20, 2017
Remove the explicit dependency on $(NODE_EXE), it always triggers a rebuild due to it being a .PHONY rule. Add-ons in test/addons/ have the same implicit dependency so it isn't completely without precedent. PR-URL: nodejs#11311 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
italoacasas
pushed a commit
that referenced
this pull request
Feb 22, 2017
Remove the explicit dependency on $(NODE_EXE), it always triggers a rebuild due to it being a .PHONY rule. Add-ons in test/addons/ have the same implicit dependency so it isn't completely without precedent. PR-URL: #11311 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Merged
|
would need a backport PR to land in v6 or v4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the explicit dependency on $(NODE_EXE), it always triggers a
rebuild due to it being a .PHONY rule. Add-ons in test/addons/ have
the same implicit dependency so it isn't completely without precedent.