Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add cases for unescape & unescapeBuffer #11326

Closed
wants to merge 1 commit into from
Closed

test: add cases for unescape & unescapeBuffer #11326

wants to merge 1 commit into from

Conversation

watilde
Copy link
Contributor

@watilde watilde commented Feb 12, 2017 •
edited
Loading

Increase coverage of querystring:

This test case will cover these lines:

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test, querystring

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 12, 2017
@mscdex mscdex added the querystring Issues and PRs related to the built-in querystring module. label Feb 12, 2017
TimothyGu
TimothyGu suggested changes Feb 12, 2017
View reviewed changes
test/parallel/test-querystring.js Outdated
@@ -304,6 +310,9 @@ assert.strictEqual(
qs.stringify(obj, null, null, { encodeURIComponent: demoEncode }),
'a=a&b=b&c=c');

// Test QueryString.unescapeBuffer
assert.strictEqual(qs.unescape('%C4%97%'), 'ė%');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer having more direct tests against qs.unescapeBuffer() in addition to the indirect ones for qs.unescape(). Here are some nice test cases for unescapeBuffer().

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing them! I've picked them and updated the test.

@watilde watilde mentioned this pull request Feb 12, 2017
Closed
3 tasks
@hiroppy
Copy link
Member

hiroppy commented Feb 12, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6367/

@jasnell
Copy link
Member

jasnell commented Feb 16, 2017

@TimothyGu ... PTAL

@TimothyGu
Copy link
Member

@watilde, sorry for not being clear. What I meant is calling qs.unescapeBuffer() directly, i.e. not though qs.unescape().

@watilde
Copy link
Contributor Author

watilde commented Feb 17, 2017

@TimothyGu To test this line, I needed calling qs.unescape() instead of qs.unescapeBuffer() to make an error by passing an option { decodeURIComponent: errDecode }.

@TimothyGu
Copy link
Member

@watilde, how about both?

@watilde
test: add cases for unescape & unescapeBuffer
9457020 
These two functions in the querystring are used as a fallback.
To test them, two test cases were added which make errors that
will be caught.
@watilde
Copy link
Contributor Author

watilde commented Feb 17, 2017

@TimothyGu Ahh that's nice! I will add it to call the both methods.

@watilde
Copy link
Contributor Author

watilde commented Feb 17, 2017

Updates:

mhdawson
mhdawson approved these changes Feb 17, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

CI run: https://ci.nodejs.org/job/node-test-pull-request/6477/

jasnell pushed a commit that referenced this pull request Feb 19, 2017
@watilde @jasnell
test: add cases for unescape & unescapeBuffer
02acea9 
These two functions in the querystring are used as a fallback.
To test them, two test cases were added which make errors that
will be caught.

PR-URL: #11326
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@hiroppy
Copy link
Member

hiroppy commented Feb 25, 2017

landed in 02acea9

@hiroppy hiroppy closed this Feb 25, 2017
@watilde watilde deleted the test-qs branch February 25, 2017 16:08
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 25, 2017
@watilde @italoacasas
test: add cases for unescape & unescapeBuffer
ff927b2 
These two functions in the querystring are used as a fallback.
To test them, two test cases were added which make errors that
will be caught.

PR-URL: nodejs#11326
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 25, 2017
Merged
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@watilde @jasnell
test: add cases for unescape & unescapeBuffer
4e9c36a 
These two functions in the querystring are used as a fallback.
To test them, two test cases were added which make errors that
will be caught.

PR-URL: #11326
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 7, 2017

This will need a backport PR if it needs to land on v4.x-staging

MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@watilde @MylesBorins
test: add cases for unescape & unescapeBuffer
f8884dd 
These two functions in the querystring are used as a fallback.
To test them, two test cases were added which make errors that
will be caught.

PR-URL: #11326
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@hiroppy hiroppy hiroppy approved these changes

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
querystring Issues and PRs related to the built-in querystring module. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@watilde @hiroppy @jasnell @TimothyGu @mhdawson @cjihrig @mscdex @nodejs-github-bot