Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors: port internal/buffer errors to internal/errors #11341

Closed
wants to merge 4 commits into from
Closed

errors: port internal/buffer errors to internal/errors #11341

wants to merge 4 commits into from

Conversation

bougarfaoui
Copy link

@bougarfaoui bougarfaoui commented Feb 13, 2017 •
edited
Loading

  • Assign codes to errors reported by internal/buffer.js

Ref: #11273

cc @jasnell

Semver-major because this updates specific error messages and converts errors over to use the new internal/errors.js mechanism.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

errors, buffer

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Feb 13, 2017
jasnell
jasnell requested changes Feb 13, 2017
View reviewed changes
lib/internal/buffer.js Outdated
@@ -24,7 +26,7 @@ exports.transcode = function transcode(source, fromEncoding, toEncoding) {
return result;

const code = icu.icuErrName(result);
const err = new Error(`Unable to transcode Buffer [${code}]`);
const err = new errors.Error('ERR_UNABlE_TRNSC_BUFF', code);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type in the code...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it would be better to fully spell out transcode and buffer

@bougarfaoui
Copy link
Author

@jasnell what do you mean by 'type in code...'

@jasnell jasnell mentioned this pull request Feb 14, 2017
Closed
80 tasks
joyeecheung
joyeecheung requested changes Feb 14, 2017
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should break test-icu-transcode.js, the test needs to be updated.

@joyeecheung joyeecheung added the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 14, 2017
@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/6429/

@jasnell jasnell added the blocked PRs that are blocked by other issues or PRs. label Apr 5, 2017
@fhinkel
Copy link
Member

fhinkel commented Jun 7, 2017

I'm closing this because it's been inactive for quite a while. Feel free to reopen or ping a collaborator to get it reopened if needed.

@fhinkel fhinkel closed this Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung requested changes

@jasnell jasnell jasnell requested changes

Assignees
No one assigned
Labels
blocked PRs that are blocked by other issues or PRs. buffer Issues and PRs related to the buffer subsystem. errors Issues and PRs related to JavaScript errors originated in Node.js core. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bougarfaoui @joyeecheung @fhinkel @jasnell @nodejs-github-bot