doc: dns examples implied string args were arrays #11350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dns
jasnell
reviewed
Feb 13, 2017
doc/api/dns.md
Outdated
| dns.lookup('example.com', options, (err, address, family) => | ||
| console.log('address: %j family: IPv%s', address, family)); | ||
| // address: "2606:2800:220:1:248:1893:25c8:1946" family: IPv6 | ||
| options.all = true; |
There was a problem hiding this comment.
Can you add a blank line and a comment here saying something like:
// When options.all = true, the result will be an ArrayJust to make the example a bit clearer.
sam-github
force-pushed
the
fix-dns-doc-examples
branch
from
6ccb068
to
de74b07
Compare
gibfahn
approved these changes
Feb 14, 2017
sam-github
force-pushed
the
fix-dns-doc-examples
branch
from
de74b07
to
eca36cf
Compare
jasnell
approved these changes
Feb 16, 2017
|
Merci! |
Fix: nodejs#11334 PR-URL: nodejs#11350 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
sam-github
force-pushed
the
fix-dns-doc-examples
branch
from
eca36cf
to
642eec1
Compare
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 20, 2017
Fix: nodejs#11334 PR-URL: nodejs#11350 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #11334
Checklist
Affected core subsystem(s)
doc