test: increase coverage of vm #11377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
reviewed
Feb 21, 2017
| } | ||
|
|
||
| assert.throws(() => { vm[method].apply(vm, args); }, | ||
| /^Error: Script execution interrupted\.$/); |
There was a problem hiding this comment.
nit: How about
const script = `process.send('${method}'); while(true) {}`;
const options = { breakOnSigint: true };
assert.throws(vm[method](script, ...args, options);(with args kinda like above… you get the idea. 😄)
DavidCai1111
force-pushed
the
test/vm-coverage
branch
2 times, most recently
from
c96ab60
to
1d6d58d
Compare
|
@addaleax Updated, PTAL. (Since the latest testing-guide says " |
|
@DavidCai1993 This test doesn’t exist in v4.x and won’t ever be backported there, so you can feel completely free to use the spread operator. :) |
DavidCai1111
force-pushed
the
test/vm-coverage
branch
from
1d6d58d
to
49e6804
Compare
|
@addaleax OK, updated 👍 |
jasnell
approved these changes
Feb 22, 2017
cjihrig
approved these changes
Feb 24, 2017
|
Landed in c7205ba, thanks for the PR! |
addaleax
pushed a commit
that referenced
this pull request
Feb 24, 2017
PR-URL: #11377 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 24, 2017
PR-URL: #11377 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
|
Does not land cleanly on v4.x due to missing files. Backport PR would be needed |
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
PR-URL: #11377 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
PR-URL: #11377 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test