Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 4.2.0 #11389

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 4.2.0 #11389

wants to merge 1 commit into from

Conversation

zkat
Copy link
Contributor

@zkat zkat commented Feb 14, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • deps
Description of Change

GOTTA GO FAST! This is a gif of the new npm search returning results in around a second for npm search web framework.

  • npm/npm#15481 Faster search! (note: this is not a breaking change, and we're working on kludging the legacy search endpoint to force older versions to do things very similarly to this) (@zkat)
  • npm/npm#11439 Put debug logs in $(npm get cache)/_logs and store multiple log files. (@KenanY) (@othiym23) (@isaacs) (@iarna)
  • npm/npm#15413 npm run-script now exits with the child process' exit code on exit. (@kapals)

Changelogs

r: @Fishrock123
r: @addaleax
r: @jasnell

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Feb 14, 2017
@Fishrock123
Copy link
Contributor

Fishrock123 commented Feb 15, 2017 •
edited
Loading

@zkat 😭

Applying: deps: upgrade npm to 4.2.0
error: deps/npm/node_modules/request/node_modules/form-data/README.md: already exists in working directory
Patch failed at 0001 deps: upgrade npm to 4.2.0

Looks like git am -3 resolves this OK though. Hopefully.

Fishrock123
Fishrock123 approved these changes Feb 15, 2017
View reviewed changes
Copy link
Contributor

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make test-npm passes, things seem fine. LGTM

@zkat
Copy link
Contributor Author

zkat commented Feb 16, 2017

I literally looked for a weirdly cased readme this time.

@targos
Copy link
Member

targos commented Feb 18, 2017

make test-npm does not pass for me (55 failing tests). It's the first time I run it so maybe I have to configure something first?

@zkat
Copy link
Contributor Author

zkat commented Feb 18, 2017

@targos can you share more details?

@targos
Copy link
Member

targos commented Feb 18, 2017

@zkat sure. here is the full output: http://pastebin.com/AP9e1eyc

@targos
Copy link
Member

targos commented Feb 18, 2017

I re-ran the tests with current master and get exactly the same failures so they are likely unrelated to this update.

@gibfahn
Copy link
Member

gibfahn commented Feb 19, 2017

@targos last I checked, make test-npm was only passing on macOS (it looks like you're running linux).

@addaleax addaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label Mar 1, 2017
@Fishrock123
Copy link
Contributor

Landed in e1834ff, so sorry I forgot! 😰

Fishrock123 pushed a commit that referenced this pull request Mar 22, 2017
@zkat @Fishrock123
deps: upgrade npm to 4.2.0
e1834ff 
PR-URL: #11389
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
@zkat @MylesBorins
deps: upgrade npm to 4.2.0
2767e2d 
PR-URL: #11389
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 28, 2017
Merged
MylesBorins added a commit that referenced this pull request Mar 28, 2017
@MylesBorins
2017-03-28, Version 7.8.0 (Current)
f04524e 
Notable changes:

* buffer:
  - do not segfault on out-of-range index (Timothy Gu)
    #11927
* crypto:
  - Fix memory leak if certificate is revoked (Tom Atkinson)
    #12089
* deps:
  * upgrade npm to 4.2.0 (Kat Marchán)
    #11389
  * fix async await desugaring in V8 (Michaël Zasso)
    #12004
* readline:
  - add option to stop duplicates in history (Danny Nemer)
    #2982
* src:
  - add native URL class (James M Snell)
    #11801

PR-URL: #12104
MylesBorins added a commit that referenced this pull request Mar 29, 2017
@MylesBorins
2017-03-28, Version 7.8.0 (Current)
9b2dd47 
Notable changes:

* buffer:
  - do not segfault on out-of-range index (Timothy Gu)
    #11927
* crypto:
  - Fix memory leak if certificate is revoked (Tom Atkinson)
    #12089
* deps:
  * upgrade npm to 4.2.0 (Kat Marchán)
    #11389
  * fix async await desugaring in V8 (Michaël Zasso)
    #12004
* readline:
  - add option to stop duplicates in history (Danny Nemer)
    #2982
* src:
  - add native URL class (James M Snell)
    #11801

PR-URL: #12104
@refack
Copy link
Contributor

refack commented Apr 8, 2017

@zkat @iarna when will he get v4.5.0. I need node-gyp@3.6.0 🤞

@italoacasas italoacasas mentioned this pull request Apr 10, 2017
Merged
2 tasks
imyller added a commit to imyller/meta-nodejs that referenced this pull request Apr 20, 2017
@imyller
2017-03-28, Version 7.8.0 (Current)
e0661dd 
    Notable changes:

    * buffer:
      - do not segfault on out-of-range index (Timothy Gu)
        nodejs/node#11927
    * crypto:
      - Fix memory leak if certificate is revoked (Tom Atkinson)
        nodejs/node#12089
    * deps:
      * upgrade npm to 4.2.0 (Kat Marchán)
        nodejs/node#11389
      * fix async await desugaring in V8 (Michaël Zasso)
        nodejs/node#12004
    * readline:
      - add option to stop duplicates in history (Danny Nemer)
        nodejs/node#2982
    * src:
      - add native URL class (James M Snell)
        nodejs/node#11801

    PR-URL: nodejs/node#12104

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fishrock123 Fishrock123 Fishrock123 approved these changes

Assignees
No one assigned
Labels
npm Issues and PRs related to the npm client dependency or the npm registry. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zkat @Fishrock123 @targos @gibfahn @refack @addaleax @nodejs-github-bot