test: enhance test-common.js #11433
Closed
test: enhance test-common.js #11433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor test-common.js so that global leak detection does not need to be disabled * add test for common.fail()
|
Perhaps we should also add a test or two for |
jasnell
approved these changes
Feb 17, 2017
gibfahn
approved these changes
Feb 17, 2017
cjihrig
approved these changes
Feb 17, 2017
lpinca
approved these changes
Feb 17, 2017
santigimeno
approved these changes
Feb 17, 2017
targos
approved these changes
Feb 18, 2017
jasnell
pushed a commit
that referenced
this pull request
Feb 19, 2017
* refactor test-common.js so that global leak detection does not need to be disabled * add test for common.fail() PR-URL: #11433 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
Landed in 7b76f82 |
addaleax
pushed a commit
that referenced
this pull request
Feb 22, 2017
* refactor test-common.js so that global leak detection does not need to be disabled * add test for common.fail() PR-URL: #11433 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
|
This would need a backport PR to land in v6 or v4 |
This was referenced Nov 29, 2023
This was referenced Dec 10, 2023
This was referenced Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
be disabled
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test