console: fixup console.dir() error handling
#11443
Closed
+57
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply the `console: do not emit error events` changes properly to `console.dir()`. This was overlooked in f18e08d (nodejs#9744). Ref: nodejs@f18e08d#commitcomment-20934407
addaleax
added
console
nodejs-github-bot
added
the
console
jasnell
approved these changes
Feb 17, 2017
|
Landed in c969047 |
addaleax
added a commit
that referenced
this pull request
Feb 21, 2017
Apply the `console: do not emit error events` changes properly to `console.dir()`. This was overlooked in f18e08d (#9744). Ref: f18e08d#commitcomment-20934407 PR-URL: #11443 Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the
console: do not emit error eventschanges properly toconsole.dir().This was overlooked in f18e08d (#9744).
Ref: f18e08d#commitcomment-20934407
/cc @Fishrock123
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
console