-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: eliminate unecessary internal/util export #11455
Conversation
The objectToString method was only being used in one place within internalUtil. It didn't make sense to have it as a separate exported mnethod.
#11128 uses |
hmm... could it not simply define it's own objectToString or use Object.prototype.toString() directly? |
(thanks for pointing that out, btw :-) ...) |
absolutely. /cc @joyeecheung |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM this function doesn't add much value
The reason to use |
hmm... I'll hold on this then. I've been thinking through a solution on trapping the instances of classes we depend on. I'll see if I can get that PR in later this week. |
I'm going to go ahead and close this without further action. There are other places where this function is looking to be used. |
The objectToString method was only being used in one place
within internalUtil. It didn't make sense to have it as
a separate exported mnethod.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
internal util