Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: clean up MaybeStackBuffer usage in i18n #11464

Closed
wants to merge 5 commits into from
Closed

src: clean up MaybeStackBuffer usage in i18n #11464

wants to merge 5 commits into from

Commits on Feb 23, 2017

  1. src: don't assume v8::Local is using-declared

    @TimothyGu
    TimothyGu committed Feb 23, 2017
    Configuration menu
    Copy the full SHA
    62539ca View commit details
    Browse the repository at this point in the history

  2. src: clean up MaybeStackBuffer 

    - Add IsInvalidated() method
- Add capacity() method for finding out the actual capacity, not the
  current size, of the buffer
- Make IsAllocated() work for invalidated buffers
- Allow multiple calls to AllocateSufficientStorage() and Invalidate()
- Assert buffer is malloc'd in Release()
- Assert buffer has not been invalidated in AllocateSufficientStorage()
- Add more descriptive comments describing the purpose of the methods
- Add cctest for MaybeStackBuffer
    @TimothyGu
    TimothyGu committed Feb 23, 2017
    Configuration menu
    Copy the full SHA
    41786c4 View commit details
    Browse the repository at this point in the history

  3. src, i18n: cleanup usage of MaybeStackBuffer 

    - Templatize AsBuffer() and create a generic version for inclusion in
  the Buffer class
- Use MaybeStackBuffer::storage()
- If possible, avoid double conversion in ToASCII()/ToUnicode()
- More descriptive assertion error in tests
    @TimothyGu
    TimothyGu committed Feb 23, 2017
    Configuration menu
    Copy the full SHA
    199d115 View commit details
    Browse the repository at this point in the history

  4. benchmark: add url.domainTo*()

    @TimothyGu
    TimothyGu committed Feb 23, 2017
    Configuration menu
    Copy the full SHA
    b5acb67 View commit details
    Browse the repository at this point in the history

  5. util: update comments

    @TimothyGu
    TimothyGu committed Feb 23, 2017
    Configuration menu
    Copy the full SHA
    0995c12 View commit details
    Browse the repository at this point in the history