build: fix newlines in addon build output #11466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
build
mscdex
force-pushed
the
build-fix-newline-output
branch
from
344a4a5 to
952eda8
Compare
jasnell
approved these changes
Feb 20, 2017
cjihrig
approved these changes
Feb 20, 2017
addaleax
approved these changes
Feb 22, 2017
There was a problem hiding this comment.
CI: https://ci.nodejs.org/job/node-test-commit/8077/
LGTM if it comes back green
Interpretation of escape sequences with echo is not as consistent across platforms as printf, so use the latter instead. PR-URL: nodejs#11466 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
mscdex
force-pushed
the
build-fix-newline-output
branch
from
952eda8 to
29ff16f
Compare
addaleax
pushed a commit
that referenced
this pull request
Feb 24, 2017
Interpretation of escape sequences with echo is not as consistent across platforms as printf, so use the latter instead. PR-URL: #11466 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
Interpretation of escape sequences with echo is not as consistent across platforms as printf, so use the latter instead. PR-URL: #11466 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
Interpretation of escape sequences with echo is not as consistent across platforms as printf, so use the latter instead. PR-URL: #11466 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Interpretation of escape sequences with echo is not as consistent across platforms as printf, so use the latter instead. PR-URL: #11466 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Interpretation of escape sequences with echo is not as consistent across platforms as printf, so use the latter instead. PR-URL: #11466 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interpretation of escape sequences with echo is not as consistent across platforms as printf, so use the latter instead.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)