Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: rename kMaxCallbacksUntilQueueIsShortened #11473

Closed
wants to merge 1 commit into from
Closed

lib: rename kMaxCallbacksUntilQueueIsShortened #11473

wants to merge 1 commit into from

Conversation

JungMinu
Copy link
Member

Refs: #11199 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

lib

@JungMinu JungMinu mentioned this pull request Feb 21, 2017
Closed
2 tasks
@JungMinu JungMinu added the lib / src Issues and PRs related to general changes in the lib or src directory. label Feb 21, 2017
@addaleax
Copy link
Member

Hm. If I understood @trevnorris’s comment in #11199 correctly, kMaxCallbacksUntilQueueIsShortened is a more accurate name, so why not keep it?

@Fishrock123
Copy link
Contributor

Apparently that name was suggested in jest of being overly accurate.

@jasnell
Copy link
Member

jasnell commented Feb 24, 2017

soo.... I assume this one is good to land? Is this the color we wanna paint the shed?

@addaleax
Copy link
Member

Tbh, I still don’t understand exactly what this does and neither name really clears it up. So I won’t stand in the way of anything. 😄

jasnell pushed a commit that referenced this pull request Feb 24, 2017
@JungMinu @jasnell
lib: rename kMaxCallbacksUntilQueueIsShortened
d42296b 
PR-URL: #11473
Ref: #11199 (comment)
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member

jasnell commented Feb 24, 2017

Landed in d42296b

@jasnell jasnell closed this Feb 24, 2017
addaleax pushed a commit that referenced this pull request Feb 24, 2017
@JungMinu @addaleax
lib: rename kMaxCallbacksUntilQueueIsShortened
a710167 
PR-URL: #11473
Ref: #11199 (comment)
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 25, 2017
Merged
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@JungMinu @jasnell
lib: rename kMaxCallbacksUntilQueueIsShortened
9c4077d 
PR-URL: #11473
Ref: #11199 (comment)
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@JungMinu @MylesBorins
lib: rename kMaxCallbacksUntilQueueIsShortened
69327f5 
PR-URL: #11473
Ref: #11199 (comment)
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JungMinu @addaleax @Fishrock123 @jasnell @danbev @cjihrig