Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add two test cases for querystring #11551

Closed
wants to merge 1 commit into from
Closed

test: add two test cases for querystring #11551

wants to merge 1 commit into from

Conversation

watilde
Copy link
Member

@watilde watilde commented Feb 25, 2017 •
edited
Loading

Test cases:

  • Cover untested branch in the state machine with the strings that its first letter is + in the key/value.
  • qs.unescapeBuffer shouldn't decode + to space.

This test increases the coverage of querystring.js:

The following branches will be skipped:

Checklist
  • make -j4 test
  • tests are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@watilde
test: add two test cases for querystring
c978769 
+ Cover untested branch in the state machine with the string
  that its first letter is `+` in the key/value.
+ `qs.unescapeBuffer` shouldn't decode `+` to space.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 25, 2017
@hiroppy hiroppy added the querystring Issues and PRs related to the built-in querystring module. label Feb 25, 2017
@jasnell
Copy link
Member

jasnell commented Feb 27, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6604/

@addaleax
Copy link
Member

addaleax commented Mar 1, 2017

Landed in acc3a80

@addaleax addaleax closed this Mar 1, 2017
addaleax pushed a commit that referenced this pull request Mar 1, 2017
@watilde @addaleax
test: add two test cases for querystring
acc3a80 
+ Cover untested branch in the state machine with the string
  that its first letter is `+` in the key/value.
+ `qs.unescapeBuffer` shouldn't decode `+` to space.

PR-URL: #11551
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@watilde watilde deleted the test/querystring branch March 1, 2017 18:27
@evanlucas
Copy link
Contributor

This is not landing cleanly on v7.x-staging. Mind submitting a backport PR?

@jasnell jasnell mentioned this pull request Apr 4, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@gibfahn
Copy link
Member

gibfahn commented Jun 17, 2017

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@hiroppy hiroppy hiroppy approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
querystring Issues and PRs related to the built-in querystring module. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@watilde @jasnell @addaleax @evanlucas @gibfahn @cjihrig @hiroppy @joyeecheung @nodejs-github-bot