Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: apply strict mode in test-repl #11575

Closed
wants to merge 1 commit into from
Closed

test: apply strict mode in test-repl #11575

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 27, 2017

Strict mode for the test will not automatically enable strict mode
in the REPL object. Enable strict mode in the test.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test repl

@Trott
test: apply strict mode in test-repl
104e462 
Strict mode for the test will not automatically enable strict mode
in the REPL object. Enable strict mode in the test.
@Trott Trott added repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests. labels Feb 27, 2017
@Trott
Copy link
Member Author

Trott commented Feb 27, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6598/

Doing it early in case this is some unexpected platform-specific thing...

@Trott
Copy link
Member Author

Trott commented Feb 27, 2017

Based in git blame, looping in @evanlucas @thefourtheye @princejwesley for potential comments.

@Trott
Copy link
Member Author

Trott commented Feb 27, 2017

CI 2: https://ci.nodejs.org/job/node-test-pull-request/6609/

@addaleax
Copy link
Member

addaleax commented Mar 1, 2017

Landed in f3b9a85

@addaleax addaleax closed this Mar 1, 2017
addaleax pushed a commit that referenced this pull request Mar 1, 2017
@Trott @addaleax
test: apply strict mode in test-repl
f3b9a85 
Strict mode for the test will not automatically enable strict mode
in the REPL object. Enable strict mode in the test.

PR-URL: #11575
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
addaleax pushed a commit that referenced this pull request Mar 5, 2017
@Trott @addaleax
test: apply strict mode in test-repl
4f92536 
Strict mode for the test will not automatically enable strict mode
in the REPL object. Enable strict mode in the test.

PR-URL: #11575
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@evanlucas evanlucas mentioned this pull request Mar 8, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Apr 17, 2017
@Trott @MylesBorins
test: apply strict mode in test-repl
f194fb3 
Strict mode for the test will not automatically enable strict mode
in the REPL object. Enable strict mode in the test.

PR-URL: #11575
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@Trott @MylesBorins
test: apply strict mode in test-repl
d4f2ef7 
Strict mode for the test will not automatically enable strict mode
in the REPL object. Enable strict mode in the test.

PR-URL: #11575
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@Trott @andrew749
test: apply strict mode in test-repl
e71e3bb 
Strict mode for the test will not automatically enable strict mode
in the REPL object. Enable strict mode in the test.

PR-URL: nodejs/node#11575
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@Trott Trott deleted the strict-repl branch January 13, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@evanlucas evanlucas evanlucas approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@addaleax addaleax addaleax approved these changes

@santigimeno santigimeno santigimeno approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @addaleax @jasnell @evanlucas @thefourtheye @santigimeno @cjihrig @MylesBorins