inspector: libuv notification on incoming message #11617
Conversation
nodejs-github-bot
added
c++
|
The code change looks good. I tested it out on Windows using VSCode and I no longer get the request timeout errors in the console. The breakpoint gets set immediately. |
src/inspector_agent.cc
Outdated
| @@ -606,6 +608,7 @@ void AgentImpl::PostIncomingMessage(InspectorAction action, int session_id, | |||
| platform_->CallOnForegroundThread(isolate, | |||
| new DispatchOnInspectorBackendTask(this)); | |||
| isolate->RequestInterrupt(InterruptCallback, this); | |||
| uv_async_send(&main_thread_req_); | |||
There was a problem hiding this comment.
Can you CHECK_EQ(0, uv_async_send(&main_thread_req_)) here?
test/inspector/inspector-helper.js
Outdated
| }; | ||
|
|
||
| exports.startNodeForInspectorTest = function(callback, opt_skip_break, | ||
| opt_script_contents) { |
There was a problem hiding this comment.
A default param might be nicer for the second argument, i.e., function(callback, arg = '--inspect-brk', contents). The string '--inspect' makes the intent clearer at the call site than a boolean does.
Style issue: we generally use camelCase for arguments and locals in JS land.
|
@bnoordhuis Thank you for the review. I addressed the comments. |
|
Landed as f01fd2a |
|
I would love to see an effort for a wholesale update of the inspect stuff on v6. If not possible please lmk |
|
I don't think v6.x has this issue, it was introduced in the refactoring that was never backported... Is there a list of inspector issues in v6? |
Currently Inspector posts a V8 "task" when a message is incoming. To
make sure messages are processed even when no JS is executed (e.g. while
waiting for I/O or timer), inspector will now post a libuv request.
Fixes: #11589
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
inspector