Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix WHATWG URL url.protocol example #11647

Closed
wants to merge 1 commit into from
Closed

doc: fix WHATWG URL url.protocol example #11647

wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

The example given in the url.protocol section of the WHATWG URL doc should print https: instead of http: for https://example.org.

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Mar 2, 2017
@mscdex mscdex added whatwg-url Issues and PRs related to the WHATWG URL implementation. and removed url Issues and PRs related to the legacy built-in url module. labels Mar 2, 2017
@jasnell
Copy link
Member

jasnell commented Mar 2, 2017

This shouldn't need the fulll 48 hours to land

jasnell pushed a commit that referenced this pull request Mar 2, 2017
@richardlau @jasnell
doc: fix WHATWG URL url.protocol example
bb5c84a 
Protocol of `https://example.org` is `https:` not `http:`.

PR-URL: #11647
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 2, 2017

Landed in bb5c84a

@jasnell jasnell closed this Mar 2, 2017
addaleax pushed a commit that referenced this pull request Mar 5, 2017
@richardlau @addaleax
doc: fix WHATWG URL url.protocol example
3e79dff 
Protocol of `https://example.org` is `https:` not `http:`.

PR-URL: #11647
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@evanlucas evanlucas mentioned this pull request Mar 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@richardlau @jasnell @TimothyGu @targos @cjihrig @mscdex @nodejs-github-bot