Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix lint issue in doctool #11658

Closed
wants to merge 1 commit into from
Closed

tools: fix lint issue in doctool #11658

wants to merge 1 commit into from

Conversation

silverwind
Copy link
Contributor

Fixes a lint issue introduced in #11167.

cc: @jasnell

@silverwind silverwind added the tools Issues and PRs related to the tools directory. label Mar 2, 2017
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 2, 2017
@silverwind silverwind mentioned this pull request Mar 2, 2017
Closed
3 tasks
@addaleax
Copy link
Member

addaleax commented Mar 2, 2017

Doesn’t the linter catch issues in tools/doc/?

@silverwind
Copy link
Contributor Author

It does, but I simply forgot to run it after my latest change in that PR. Running make test now and will land afterwards.

jasnell
jasnell approved these changes Mar 2, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's fast track this to unbreak CI

@jasnell
Copy link
Member

jasnell commented Mar 2, 2017

CI Linter: https://ci.nodejs.org/job/node-test-linter/7369/

jasnell pushed a commit that referenced this pull request Mar 2, 2017
@silverwind @jasnell
tools: fix lint issue in doctool
172be50 
PR-URL: #11658
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 2, 2017

Landed in 172be50

@jasnell jasnell closed this Mar 2, 2017
@silverwind
Copy link
Contributor Author

Thanks @jasnell. For the record, the issue happened because my workflow on that PR was basically

rm out/doc/api && make doc-only && make docopen

I'll have to remember to actually run tests on that type of change too, because tests partially cover the doctool

@silverwind silverwind deleted the fix-lint branch March 2, 2017 17:56
@jasnell
Copy link
Member

jasnell commented Mar 2, 2017

It's all good. I just did a lint check on this particular PR. You make want to do a full CI run just to make sure that everything else is still good.

@silverwind
Copy link
Contributor Author

make test passed locally, so it should be good.

@evanlucas
Copy link
Contributor

This is not landing cleanly on v7.x-staging. Mind submitting a backport PR?

@silverwind
Copy link
Contributor Author

There's three PRs that should land in tandem, I will do a backport once the last one lands.

#11167
#11658
#11697

silverwind added a commit to silverwind/node that referenced this pull request Mar 8, 2017
@silverwind
tools: fix lint issue in doctool
6e0d53b 
PR-URL: nodejs#11658
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@silverwind silverwind mentioned this pull request Mar 8, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 13, 2017
@silverwind @italoacasas
tools: fix lint issue in doctool
5a9e30f 
PR-URL: nodejs#11658
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

do we want to backport to v6.x?

@silverwind
Copy link
Contributor Author

Backport in #13054

gibfahn pushed a commit that referenced this pull request May 16, 2017
@silverwind @gibfahn
tools: fix lint issue in doctool
5fd1593 
PR-URL: #11658
Backport-PR-URL: #13054
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request May 16, 2017
Closed
MylesBorins pushed a commit that referenced this pull request May 18, 2017
@silverwind @MylesBorins
tools: fix lint issue in doctool
7135a7b 
PR-URL: #11658
Backport-PR-URL: #13054
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
silverwind added a commit to silverwind/node that referenced this pull request May 18, 2017
@silverwind
tools: fix lint issue in doctool
8098f49 
PR-URL: nodejs#11658
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit to gibfahn/node that referenced this pull request Jun 17, 2017
@silverwind @gibfahn
tools: fix lint issue in doctool
e70cb6a 
PR-URL: nodejs#11658
Backport-PR-URL: nodejs#13054
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit that referenced this pull request Jun 20, 2017
@silverwind @gibfahn
tools: fix lint issue in doctool
c881b2c 
PR-URL: #11658
Backport-PR-URL: #13054
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
@silverwind @MylesBorins
tools: fix lint issue in doctool
beb8485 
PR-URL: #11658
Backport-PR-URL: #13054
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@silverwind @addaleax @jasnell @evanlucas @MylesBorins @lpinca @gibfahn @nodejs-github-bot