-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add Daijiro Wachi
to collaborators
#11676
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanlucas
approved these changes
Mar 3, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Welcome aboard!
Landed 4cb9f4f |
watilde
added a commit
that referenced
this pull request
Mar 3, 2017
PR-URL: #11676 Reviewed-By: Evan Lucas <evanlucas@me.com>
Welcome!!! |
addaleax
pushed a commit
that referenced
this pull request
Mar 5, 2017
PR-URL: #11676 Reviewed-By: Evan Lucas <evanlucas@me.com>
Merged
evanlucas
added a commit
that referenced
this pull request
Mar 8, 2017
evanlucas
added a commit
that referenced
this pull request
Mar 8, 2017
imyller
added a commit
to imyller/meta-nodejs
that referenced
this pull request
Mar 16, 2017
Notable changes: * doc: add `Daijiro Wachi` to collaborators (Daijiro Wachi) nodejs/node#11676 * tty: add ref() so process.stdin.ref() etc. work (Ben Schmidt) nodejs/node#7360 * util: fix inspecting symbol key in string (Ali BARIN) nodejs/node#11672 PR-URL: nodejs/node#11745 Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
jungx098
pushed a commit
to jungx098/node
that referenced
this pull request
Mar 21, 2017
Notable changes: * doc: add `Daijiro Wachi` to collaborators (Daijiro Wachi) nodejs#11676 * tty: add ref() so process.stdin.ref() etc. work (Ben Schmidt) nodejs#7360 * util: fix inspecting symbol key in string (Ali BARIN) nodejs#11672 PR-URL: nodejs#11745
MylesBorins
pushed a commit
that referenced
this pull request
Apr 17, 2017
PR-URL: #11676 Reviewed-By: Evan Lucas <evanlucas@me.com>
A++. Glad to backport. Welcome to v6.x 😄 |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2017
PR-URL: #11676 Reviewed-By: Evan Lucas <evanlucas@me.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
PR-URL: nodejs/node#11676 Reviewed-By: Evan Lucas <evanlucas@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc