Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: drop the NODE_ISOLATE_SLOT macro #11692

Closed
wants to merge 1 commit into from
Closed

src: drop the NODE_ISOLATE_SLOT macro #11692

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Mar 5, 2017

The NODE_ISOLATE_SLOT macro has been unused since c3cd453.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

CI: https://ci.nodejs.org/job/node-test-commit/8269/

@addaleax
src: drop the NODE_ISOLATE_SLOT macro
5edf81d 
The `NODE_ISOLATE_SLOT` macro has been unused since c3cd453.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 5, 2017
@fhinkel
Copy link
Member

fhinkel commented Mar 9, 2017

Thanks, landed in 6d16048.

@fhinkel fhinkel closed this Mar 9, 2017
fhinkel pushed a commit that referenced this pull request Mar 9, 2017
@addaleax @fhinkel
src: drop the NODE_ISOLATE_SLOT macro
6d16048 
The `NODE_ISOLATE_SLOT` macro has been unused since c3cd453.

PR-URL: #11692
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@addaleax addaleax deleted the drop-node_isolate_slot branch March 9, 2017 16:35
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 13, 2017
@addaleax @italoacasas
src: drop the NODE_ISOLATE_SLOT macro
1da2afc 
The `NODE_ISOLATE_SLOT` macro has been unused since c3cd453.

PR-URL: nodejs#11692
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@italoacasas italoacasas mentioned this pull request Mar 13, 2017
Merged
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
@addaleax @jungx098
src: drop the NODE_ISOLATE_SLOT macro
159425d 
The `NODE_ISOLATE_SLOT` macro has been unused since c3cd453.

PR-URL: nodejs#11692
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@MylesBorins
Copy link
Contributor

doesn't look like this should be backported. lmk if I'm wrong

@aliscco aliscco mentioned this pull request Jun 23, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Dec 1, 2023
Open
@aliscco aliscco mentioned this pull request Dec 2, 2023
Open
@aliscco aliscco mentioned this pull request Jan 9, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Jan 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@addaleax @fhinkel @MylesBorins @bnoordhuis @jasnell @cjihrig @nodejs-github-bot