dgram: refactor dgram to module.exports #11696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor dgram module to use the more efficient
module.exports = {} pattern.
claudiorodriguez
added
the
dgram
|
What's more efficient about this? I can see the benchmark, but are you saying every time we access one of the exported properties we take a perf hit? Even if so, this is so not on any hot code path, I see little point in doing this. Even if we did change this, we would have to change all built-in modules to follow that pattern. Has anyone discussed doing that yet? |
cjihrig
approved these changes
Mar 6, 2017
TimothyGu
approved these changes
Mar 6, 2017
lpinca
approved these changes
Mar 6, 2017
|
@TimothyGu Thank you, I wasn't aware this was already ongoing. LGTM 👍 |
|
@TimothyGu I think those are already fast properties without being exported this way? See #11430 |
jasnell
approved these changes
Mar 6, 2017
fhinkel
approved these changes
Mar 9, 2017
|
Thanks! Landed in a9e64a8. |
fhinkel
pushed a commit
that referenced
this pull request
Mar 9, 2017
Refactor dgram module to use the more efficient
module.exports = {} pattern.
PR-URL: #11696
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Mar 13, 2017
Refactor dgram module to use the more efficient
module.exports = {} pattern.
PR-URL: nodejs#11696
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
jungx098
pushed a commit
to jungx098/node
that referenced
this pull request
Mar 21, 2017
Refactor dgram module to use the more efficient
module.exports = {} pattern.
PR-URL: nodejs#11696
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
|
should we backport? |
|
I've labelled this as don't land. I believe that these optimizations were made with turbofan in mind. |
|
-1 on backporting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor dgram module to use the more efficient
module.exports = {} pattern.
See #11611
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
dgram