Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: fix punycode and get-ciphers benchmark #11720

Closed
wants to merge 1 commit into from
Closed

benchmark: fix punycode and get-ciphers benchmark #11720

wants to merge 1 commit into from

Conversation

bzoz
Copy link
Contributor

@bzoz bzoz commented Mar 6, 2017

I've missed two for loops without initialization in #9615. This adds missing i = 0 to those loops in punycode and get-ciphers benchmarks.

Sorry for the trouble.

/cc @mcollina @jasnell

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

benchmarks

@bzoz
benchmark: fix punycode and get-ciphers benchmark
3be2872 
Add missing 'i=0' from for-loops from punycode and get-ciphers
benchmarks.
@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Mar 6, 2017
@mscdex mscdex added crypto Issues and PRs related to the crypto subsystem. punycode Issues and PRs related to the punycode module bundled in Node.js. labels Mar 6, 2017
bzoz added a commit to JaneaSystems/node that referenced this pull request Mar 8, 2017
@bzoz
benchmark: remove benchmarks forced optimizations
f1f899a 
Removes all instances of %OptimizeFunctionOnNextCall from benchmarks

Refs: nodejs#9615
Refs: nodejs#11720
@bzoz bzoz mentioned this pull request Mar 8, 2017
Closed
3 tasks
@bzoz
Copy link
Contributor Author

bzoz commented Mar 9, 2017

Landed in 6df23fa

@bzoz bzoz closed this Mar 9, 2017
bzoz added a commit that referenced this pull request Mar 9, 2017
@bzoz
benchmark: fix punycode and get-ciphers benchmark
6df23fa 
Add missing 'i=0' from for-loops from punycode and get-ciphers
benchmarks.

PR-URL: #11720
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
@bzoz @jungx098
benchmark: fix punycode and get-ciphers benchmark
81fde6a 
Add missing 'i=0' from for-loops from punycode and get-ciphers
benchmarks.

PR-URL: nodejs#11720
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 21, 2017
@bzoz @italoacasas
benchmark: remove benchmarks forced optimizations
f48763c 
Removes all instances of %OptimizeFunctionOnNextCall from benchmarks

Refs: nodejs#9615
Refs: nodejs#11720
@jasnell jasnell mentioned this pull request Apr 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. crypto Issues and PRs related to the crypto subsystem. punycode Issues and PRs related to the punycode module bundled in Node.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@bzoz @jasnell @lpinca @TimothyGu @cjihrig @mscdex @MylesBorins @nodejs-github-bot