Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make PercentDecode return void #11922

Merged
merged 1 commit into from
Mar 22, 2017
Merged

src: make PercentDecode return void #11922

merged 1 commit into from
Mar 22, 2017

Conversation

TimothyGu
Copy link
Member

It only returns 0, nor is it likely to have any error conditions in the future.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src, url

@TimothyGu TimothyGu added c++ Issues and PRs that require attention from people who are familiar with C++. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Mar 19, 2017
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Mar 19, 2017
@TimothyGu
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/6917/

joyeecheung
joyeecheung approved these changes Mar 20, 2017
View reviewed changes
src/node_url.h
@@ -403,7 +403,6 @@ static inline int PercentDecode(const char* input,
pointer += 3;
}
}
return 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside: c in the else block above is casted twice.

@TimothyGu
src: make PercentDecode return void
d231236 
It only returns 0, nor is it likely to have any error conditions in the
future.

PR-URL: nodejs#11922
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TimothyGu
Copy link
Member Author

Landed in d231236.

@TimothyGu TimothyGu closed this Mar 22, 2017
@TimothyGu TimothyGu deleted the url-percent-void branch March 22, 2017 01:22
@TimothyGu TimothyGu merged commit d231236 into nodejs:master Mar 22, 2017
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
@TimothyGu @MylesBorins
src: make PercentDecode return void
019a20a 
It only returns 0, nor is it likely to have any error conditions in the
future.

PR-URL: #11922
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 28, 2017
Merged
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TimothyGu @bnoordhuis @jasnell @cjihrig @joyeecheung @nodejs-github-bot