benchmark: harmonize progress bar and stderr output #11925
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
benchmark
_benchmark_progress.js
does not work well with stderr output:It sticks together with error messages which throw and abort runs. See this comment for an example.
It still sticks together with error messages which do not throw and do not abort runs. At that, it starts to duplicate with each such message. For example, there is
misc/function_call
which callsconsole.error()
most of the time themisc
suite is launched. So the output is something like this:Till some drastic solution is applied, this commit just adds a space in the end of the bar for minimal readability. So the abovementioned output could be at least something like this: