Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(v7.x backport) test: refactor test-util-inspect.js #11966

Closed
wants to merge 1 commit into from
Closed

(v7.x backport) test: refactor test-util-inspect.js #11966

wants to merge 1 commit into from

Conversation

aqrln
Copy link
Contributor

@aqrln aqrln commented Mar 21, 2017 •
edited
Loading

Backport of #11779 to v7.x

/cc @italoacasas @cjihrig

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@aqrln
test: refactor test-util-inspect.js
09ed6b3 
* Enclose tests that used to introduce module-level variables into
  their own scopes.
* Replace ES5 anonymous functions with arrow functions where it makes
  sense.
* And make one arrow function a regular function thus fixing a bug in a
  getter inside an object created in "Array with dynamic properties"
  test.  This getter has never been invoked though, so the test hasn't been
  failing.
* Convert snake_case identifiers to camelCase.
* Make some variable names more readable.
* Replace regular expressions in maxArrayLength tests with simple
  assert.strictEquals() and assert(...endsWith()) checks, as suggested
  in <nodejs#11576 (comment)>.

PR-URL: nodejs#11779
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v7.x labels Mar 21, 2017
@mscdex mscdex added the util Issues and PRs related to the built-in util module. label Mar 21, 2017
@aqrln
Copy link
Contributor Author

aqrln commented Apr 11, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7319/

@aqrln aqrln mentioned this pull request Apr 11, 2017
Merged
2 tasks
@evanlucas
Copy link
Contributor

Running CI one more time https://ci.nodejs.org/job/node-test-pull-request/7795/

evanlucas
evanlucas approved these changes May 2, 2017
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is happy

@evanlucas
Copy link
Contributor

landed in 9bdf62f. Thanks!

@evanlucas evanlucas closed this May 2, 2017
@aqrln aqrln deleted the pr11779-backport-v7.x branch May 3, 2017 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlucas evanlucas evanlucas approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aqrln @evanlucas @mscdex @nodejs-github-bot