Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(v7.x backport) test: add arrow functions to test-util-inspect #11967

Closed
wants to merge 1 commit into from
Closed

(v7.x backport) test: add arrow functions to test-util-inspect #11967

wants to merge 1 commit into from

Conversation

aqrln
Copy link
Contributor

@aqrln aqrln commented Mar 21, 2017 •
edited
Loading

Backport of #11781 to v7.x

/cc @italoacasas @cjihrig

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@aqrln
test: add arrow functions to test-util-inspect
b326508 
Even though arrow functions and ES5 anonymous functions are technically
the same for util.js, it won't hurt to test both.  The same goes for
async functions.

PR-URL: nodejs#11781
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
@mscdex mscdex mentioned this pull request Mar 21, 2017
Closed
@mscdex mscdex added test Issues and PRs related to the tests. util Issues and PRs related to the built-in util module. v7.x labels Mar 21, 2017
@aqrln
Copy link
Contributor Author

aqrln commented Apr 11, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7318/

@aqrln aqrln mentioned this pull request Apr 11, 2017
Merged
2 tasks
evanlucas
evanlucas approved these changes May 2, 2017
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is happy

@evanlucas
Copy link
Contributor

landed in fe45a37. Thanks!

@evanlucas evanlucas closed this May 2, 2017
@aqrln aqrln deleted the pr11781-backport-v7.x branch May 3, 2017 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlucas evanlucas evanlucas approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aqrln @evanlucas @mscdex