Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(v6.x backport) test: add arrow functions to test-util-inspect #11970

Closed
wants to merge 1 commit into from
Closed

(v6.x backport) test: add arrow functions to test-util-inspect #11970

wants to merge 1 commit into from

Conversation

aqrln
Copy link
Contributor

@aqrln aqrln commented Mar 21, 2017 •
edited
Loading

Backport of #11781 to v6.x

/cc @MylesBorins @Fishrock123

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v6.x labels Mar 21, 2017
@mscdex mscdex added the util Issues and PRs related to the built-in util module. label Mar 21, 2017
@aqrln
test: add arrow functions to test-util-inspect
57609e7 
Even though arrow functions and ES5 anonymous functions are technically
the same for util.js, it won't hurt to test both.

PR-URL: nodejs#11781
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
@aqrln
Copy link
Contributor Author

aqrln commented Mar 22, 2017

Applied the commit on top of the new HEAD of v6.x-staging. I was kinda surprised to open the PR and see all those commits 😄

@evanlucas
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/7017/

MylesBorins pushed a commit that referenced this pull request Apr 13, 2017
@aqrln @MylesBorins
test: add arrow functions to test-util-inspect
533e565 
Even though arrow functions and ES5 anonymous functions are technically
the same for util.js, it won't hurt to test both.

Backport-PR-URL: #11970
PR-URL: #11781
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
@MylesBorins
Copy link
Contributor

landed in 533e565

@aqrln aqrln deleted the pr11781-backport-v6.x branch April 17, 2017 22:47
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@aqrln @MylesBorins
test: add arrow functions to test-util-inspect
9162316 
Even though arrow functions and ES5 anonymous functions are technically
the same for util.js, it won't hurt to test both.

Backport-PR-URL: #11970
PR-URL: #11781
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@aqrln @andrew749
test: add arrow functions to test-util-inspect
eabc6f3 
Even though arrow functions and ES5 anonymous functions are technically
the same for util.js, it won't hurt to test both.

Backport-PR-URL: nodejs/node#11970
PR-URL: nodejs/node#11781
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlucas evanlucas evanlucas approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aqrln @evanlucas @MylesBorins @jasnell @mscdex @nodejs-github-bot