Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: testing validity of prefix in mkdtempSync #12009

Closed
wants to merge 1 commit into from
Closed

test: testing validity of prefix in mkdtempSync #12009

wants to merge 1 commit into from

Conversation

lucamaraschi
Copy link
Contributor

This test is checking for the validity of the path used as parameter
for mkdtempSync

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows [commit guidelines][]
Affected core subsystem(s)

test fs

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 23, 2017
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Mar 23, 2017
cjihrig
cjihrig approved these changes Mar 24, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test code LGTM, but why is test/parallel/test-mkdtemp-prefix-check.js showing up in the diff as "No changes"?

@targos
Copy link
Member

targos commented Mar 24, 2017

@cjihrig
It's a new (empty) file.

@cjihrig
Copy link
Contributor

cjihrig commented Mar 24, 2017

@targos thanks. @lucamaraschi can you remove the empty file?

@lucamaraschi
test: testing validity of prefix in mkdtempSync
6da040b 
This test is checking for the validity of the path used as parameter
for mkdtempSync
@lucamaraschi lucamaraschi force-pushed the test-mkdtemp-sync-prefix-check branch from a56c067 to 6da040b Compare March 24, 2017 22:57
@cjihrig
Copy link
Contributor

cjihrig commented Mar 25, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7030/

@fhinkel
Copy link
Member

fhinkel commented Mar 26, 2017

Landed in c2ead7e

@fhinkel fhinkel closed this Mar 26, 2017
fhinkel pushed a commit that referenced this pull request Mar 26, 2017
@lucamaraschi @fhinkel
test: test validity of prefix in mkdtempSync
c2ead7e 
This test is checking for the validity of the path used as parameter
for mkdtempSync.

PR-URL: #12009
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
@lucamaraschi @MylesBorins
test: test validity of prefix in mkdtempSync
414df6c 
This test is checking for the validity of the path used as parameter
for mkdtempSync.

PR-URL: #12009
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 28, 2017
Merged
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
Merged
2 tasks
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
@lucamaraschi @MylesBorins
test: test validity of prefix in mkdtempSync
ca0cb61 
This test is checking for the validity of the path used as parameter
for mkdtempSync.

PR-URL: #12009
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@lucamaraschi @MylesBorins
test: test validity of prefix in mkdtempSync
f23377c 
This test is checking for the validity of the path used as parameter
for mkdtempSync.

PR-URL: #12009
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@lucamaraschi @andrew749
test: test validity of prefix in mkdtempSync
a70de4a 
This test is checking for the validity of the path used as parameter
for mkdtempSync.

PR-URL: nodejs/node#12009
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lucamaraschi @targos @cjihrig @fhinkel @jasnell @mscdex @MylesBorins @nodejs-github-bot