Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add variable arguments support for Argv #12166

Closed
wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Apr 2, 2017

At the moment Argv only supports three arguments which fulfilled my
requirements when working on #9163.

This commit adds support for a variable number of arguments. There is
also a no-args constructor that is the equivalent to running "node -p
process.version" which is hopefully alright as a default.

Refs: #9163

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

At the moment Argv only supports three arguments which fulfilled my
requirements when working on nodejs#9163.

This commit adds support for a variable number of arguments. There is
also a no-args constructor that is the equivalent to running "node -p
process.version" which is hopefully alright as a default.

Refs: nodejs#9163
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 2, 2017
@Trott Trott added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 2, 2017
@jasnell
Copy link
Member

jasnell commented Apr 4, 2017

jasnell pushed a commit that referenced this pull request Apr 4, 2017
At the moment Argv only supports three arguments which fulfilled my
requirements when working on #9163.

This commit adds support for a variable number of arguments. There is
also a no-args constructor that is the equivalent to running "node -p
process.version" which is hopefully alright as a default.

PR-URL: #12166
Ref: #9163
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Apr 4, 2017

Landed in 5ccaba4

@jasnell jasnell closed this Apr 4, 2017
@jasnell jasnell mentioned this pull request Apr 4, 2017
@danbev danbev deleted the varargs branch April 6, 2017 05:52
@italoacasas
Copy link
Contributor

cc @danbev

@danbev
Copy link
Contributor Author

danbev commented Apr 19, 2017

@italoacasas Sorry I missed this message. Would you like me to open at PR against v7.x-staging with a backport?

@gibfahn
Copy link
Member

gibfahn commented Jun 17, 2017

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants