Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: create test_addons function #12204

Closed
wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Apr 4, 2017

test/addons/.buildstamp and test/addons-napi/.buildstamp targets are
very similar except that they operate on different directories. This
commit extracts the common parts into a function to avoid the
duplication.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Sorry, something went wrong.

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Apr 4, 2017
@danbev
Copy link
Contributor Author

danbev commented Apr 4, 2017

--nodedir="$$PWD" || exit 1 ; \
done
touch $(2)
endef
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, @Fishrock123 recently asked on IRC whether we could parallelize addon building… any chance there’s an easy way to do this in make?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not off the top of my head (only know about the -j flag to make for that) but I'll take a look and see what options exist.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@addaleax I've added a commit now for this. Let me know what you think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created #12230 since making the building of addons parallel does not really relate to this PR. I'll remove also remove that commit from this PR.

@danbev
Copy link
Contributor Author

danbev commented Apr 4, 2017

I windows failure looks unrelated to this commit:

not ok 32 parallel/test-cli-syntax
  ---
  duration_ms: 3.104
  severity: fail
  stack: |-
    
    assert.js:82
      throw new assert.AssertionError({
      ^
    AssertionError: 'c:\\workspace\\node-test-binary-windows\\RUN_SUBSET\\2\\VS_VERSION\\vcbt2015\\label\\win10\\Release\\node.exe: either --check o === 'c:\\workspace\\node-test-binary-windows\\RUN_SUBSET\\2\\VS_VERSION\\vcbt2015\\label\\win10\\Release\\node.exe: either --check o
        at c:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vcbt2015\label\win10\test\parallel\test-cli-syntax.js:127:12
        at Array.forEach (native)
        at c:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vcbt2015\label\win10\test\parallel\test-cli-syntax.js:123:20
        at Array.forEach (native)
        at Object.<anonymous> (c:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vcbt2015\label\win10\test\parallel\test-cli-syntax.js:122:19)
        at Module._compile (module.js:607:30)
        at Object.Module._extensions..js (module.js:618:10)
        at Module.load (module.js:516:32)
        at tryModuleLoad (module.js:466:12)
        at Function.Module._load (module.js:458:3)

@Trott
Copy link
Member

Trott commented Apr 4, 2017

The Windows failure was a problem on the master branch and has since been fixed.

@danbev
Copy link
Contributor Author

danbev commented Apr 4, 2017

The Windows failure was a problem on the master branch and has since been fixed.

Thanks for that, I'll rebase and rerun Ci.

@danbev danbev force-pushed the addons_test_function branch from 476b1cc to 1bd2f8e Compare April 4, 2017 17:30
@danbev
Copy link
Contributor Author

danbev commented Apr 4, 2017

@danbev
Copy link
Contributor Author

danbev commented Apr 4, 2017

@mscdex mscdex added addons Issues and PRs related to native addons. test Issues and PRs related to the tests. labels Apr 4, 2017
test/addons/.buildstamp and test/addons-napi/.buildstamp targets are
very similar except that they operate on different directories. This
commit extracts the common parts into a function to avoid the
duplication.
@danbev danbev force-pushed the addons_test_function branch from fff95d6 to 1fb7d60 Compare April 5, 2017 11:26
@danbev
Copy link
Contributor Author

danbev commented Apr 5, 2017

Closing in favour of #12231

@danbev danbev closed this Apr 5, 2017
@refack refack added the embedding Issues and PRs related to embedding Node.js in another project. label Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addons Issues and PRs related to native addons. build Issues and PRs related to build files or the CI. embedding Issues and PRs related to embedding Node.js in another project. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants