Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo in CHANGELOG_V6.md #12206

Closed
wants to merge 1 commit into from
Closed

doc: fix typo in CHANGELOG_V6.md #12206

wants to merge 1 commit into from

Conversation

l2dy
Copy link
Contributor

@l2dy l2dy commented Apr 4, 2017

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 4, 2017
jasnell
jasnell approved these changes Apr 4, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not need to wait the 48 hours to land

vsemozhetbyt pushed a commit that referenced this pull request Apr 4, 2017
@l2dy @vsemozhetbyt
doc: fix typo in CHANGELOG_V6.md
c79b081 
PR-URL: #12206
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@vsemozhetbyt
Copy link
Contributor

Landed in c79b081

Thank you, @l2dy!

@jasnell jasnell mentioned this pull request Apr 4, 2017
Closed
@l2dy l2dy deleted the typo branch April 5, 2017 01:14
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@l2dy @vsemozhetbyt @jasnell @lpinca @TimothyGu @cjihrig @italoacasas @gibfahn @nodejs-github-bot