Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: enforce two arguments in assert.throws #12270

Merged
merged 2 commits into from
Apr 13, 2017
Merged

tools: enforce two arguments in assert.throws #12270

merged 2 commits into from
Apr 13, 2017

Commits on Apr 13, 2017

  1. test: add second argument to assert.throws 

    This adds RegExp or error constructor arguments to the remaining places
where it is missing in preparation for the commit that will enforce the
presence of at least two arguments.

PR-URL: nodejs#12270
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @targos
    targos committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    9de2e15 View commit details
    Browse the repository at this point in the history

  2. tools: enforce two arguments in assert.throws 

    Enables the requireTwo option of our custom rule.

PR-URL: nodejs#12270
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @targos
    targos committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    a4b9c58 View commit details
    Browse the repository at this point in the history