Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http_parser: assert on incoming argument's type #12288

Closed
wants to merge 1 commit into from
Closed

http_parser: assert on incoming argument's type #12288

wants to merge 1 commit into from

Commits on Jun 5, 2017

  1. http_parser: assert on incoming argument's type 

    Unchecked argument conversion in Parser::Consume crashes node
in an slightly undesirable manner - 'unreachable code' in parser.

Make sure we validate the incoming type at the earliest point.

Refs: nodejs#12178
    @gireeshpunathil
    gireeshpunathil committed Jun 5, 2017
    Configuration menu
    Copy the full SHA
    e340d28 View commit details
    Browse the repository at this point in the history