Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade v8 to 4.2.77.10 (next) #1232

Merged
merged 2 commits into from
Mar 27, 2015
Merged

Conversation

bnoordhuis
Copy link
Member

R=@indutny?

I disabled postmortem debugging because it's broken again and I deleted parallel/test-v8-features because it's obsolete now that ES6 classes are enabled by default.

https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/358/

@indutny
Copy link
Member

indutny commented Mar 21, 2015

Oh, postmortem!

Let me figure it out first, and then land with a floating patch while Google will be reviewing it.

@rvagg
Copy link
Member

rvagg commented Mar 21, 2015

fixup! are those commit messages intended to be final? Can we come up with a convention that fits category: message so changelogs remain consistent?

@nstepien
Copy link
Contributor

@rvagg
Pretty sure it's meant to be rebased, following git's convention.

@bnoordhuis
Copy link
Member Author

Exactly. :-)

I'm going to squash the PR into a single commit before landing it. The fixup! commits are for easier reviewing.

@mscdex mscdex added the v8 engine Issues and PRs related to the V8 dependency. label Mar 22, 2015
@bnoordhuis
Copy link
Member Author

@indutny Ping.

@indutny
Copy link
Member

indutny commented Mar 23, 2015

Got distracted, looking again into it.

@indutny
Copy link
Member

indutny commented Mar 23, 2015

@bnoordhuis here is a fix:

diff --git a/deps/v8/tools/gen-postmortem-metadata.py b/deps/v8/tools/gen-postmortem-metadata.py
index 62e103a..d5defa7 100644
--- a/deps/v8/tools/gen-postmortem-metadata.py
+++ b/deps/v8/tools/gen-postmortem-metadata.py
@@ -91,7 +91,7 @@ consts_misc = [
     { 'name': 'prop_idx_first',
         'value': 'DescriptorArray::kFirstIndex' },
     { 'name': 'prop_type_field',
-        'value': 'FIELD' },
+        'value': 'DATA' },
     { 'name': 'prop_type_mask',
         'value': 'PropertyDetails::TypeField::kMask' },
     { 'name': 'prop_index_mask',

Please float it up. I'm submitting a CL atm.

@indutny
Copy link
Member

indutny commented Mar 23, 2015

This commit applies some secondary changes in order to make `make test`
pass cleanly:

* disable broken postmortem debugging in common.gypi

* drop obsolete strict mode test in parallel/test-repl

* drop obsolete test parallel/test-v8-features

PR-URL: nodejs#1232
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Cherry-pick https://codereview.chromium.org/1033733003 from upstream
and re-enable postmortem debugging.

PR-URL: nodejs#1232
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@bnoordhuis bnoordhuis merged commit 41c00a2 into nodejs:next Mar 27, 2015
@bnoordhuis bnoordhuis deleted the v8-4.2.77.10 branch March 27, 2015 11:17
@bnoordhuis
Copy link
Member Author

Landed in 336dc08...41c00a2. You didn't explicitly LGTM it but I added you as a reviewer, Fedor.

@indutny
Copy link
Member

indutny commented Mar 27, 2015

Oh, sorry for that! LGTM ;)

bnoordhuis added a commit that referenced this pull request Apr 28, 2015
This commit applies some secondary changes in order to make `make test`
pass cleanly:

* disable broken postmortem debugging in common.gypi

* drop obsolete strict mode test in parallel/test-repl

* drop obsolete test parallel/test-v8-features

PR-URL: #1232
Reviewed-By: Fedor Indutny <fedor@indutny.com>
bnoordhuis added a commit that referenced this pull request Apr 28, 2015
Cherry-pick https://codereview.chromium.org/1033733003 from upstream
and re-enable postmortem debugging.

PR-URL: #1232
Reviewed-By: Fedor Indutny <fedor@indutny.com>
bnoordhuis added a commit that referenced this pull request Apr 28, 2015
Cherry-pick https://codereview.chromium.org/1033733003 from upstream
and re-enable postmortem debugging.

PR-URL: #1232
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@rvagg rvagg mentioned this pull request Apr 29, 2015
@rvagg rvagg added the semver-major PRs that contain breaking changes and should be released in the next major version. label May 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants