Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove experimental warning for inspect #12352

Closed
wants to merge 1 commit into from
Closed

src: remove experimental warning for inspect #12352

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Apr 12, 2017 •
edited
Loading

  • Removes "experimental" warning.

This is broken out of #11207 which also included changes to the message the inspector prints.

@joshgav's authorship is maintained on the commit

CI: https://ci.nodejs.org/job/node-test-pull-request/7343/

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x inspector Issues and PRs related to the V8 inspector protocol labels Apr 12, 2017
@MylesBorins MylesBorins mentioned this pull request Apr 12, 2017
Closed
4 tasks
@MylesBorins MylesBorins added this to the 8.0.0 milestone Apr 12, 2017
@MylesBorins
Copy link
Contributor Author

/cc @jasnell

@MylesBorins MylesBorins force-pushed the stable-inspect branch 2 times, most recently from c1a1c11 to 72f936e Compare April 12, 2017 05:38
@MylesBorins MylesBorins mentioned this pull request Apr 12, 2017
Closed
@MylesBorins MylesBorins changed the title src: remove experiment warning for inspect src: remove experimental warning for inspect Apr 12, 2017
@MylesBorins MylesBorins mentioned this pull request Apr 12, 2017
Closed
@joshgav @MylesBorins
src: remove experimental warning for inspect
4e6fdcd 
* Removes "experimental" warning.

Fixes: nodejs#11770
PR-URL: nodejs#12352
Reviewed-By: _tbd_
Reviewed-By: _tbd_
jasnell
jasnell approved these changes Apr 12, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@jasnell
Copy link
Member

jasnell commented Apr 12, 2017

Looks like some ci failures tho

@MylesBorins
Copy link
Contributor Author

Got a little overzealous removing things. Should work fine now... CI kicked off once more

@jasnell
Copy link
Member

jasnell commented Apr 12, 2017

Remove all the things!

@MylesBorins
Copy link
Contributor Author

Are people ok with this landed in less than 48 hours?

evanlucas
evanlucas approved these changes Apr 12, 2017
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member

jasnell commented Apr 12, 2017

I'm good with it, yes. It would be good to get this in before I do the RC.0 build

@Fishrock123
Copy link
Contributor

I personally would greatly prefer if some sort of generic URL was printed along with this change, not sure if that is standardized enough yet?

@MylesBorins
Copy link
Contributor Author

@Fishrock123 there is another thread for changing the message, we couldn't reach consensus on that so I wanted to get this in first

jasnell pushed a commit that referenced this pull request Apr 13, 2017
@joshgav @jasnell
src: remove experimental warning for inspect
a4125a3 
* Removes "experimental" warning.

Fixes: #11770
PR-URL: #12352
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
@jasnell
Copy link
Member

jasnell commented Apr 13, 2017

Landed in a4125a3

@jasnell jasnell closed this Apr 13, 2017
@jkrems jkrems mentioned this pull request Apr 13, 2017
Closed
14 tasks
cjihrig added a commit to cjihrig/node that referenced this pull request Apr 14, 2017
@cjihrig
doc: remove inspector experimental warning
b0ab9b3 
Refs: nodejs#12352
@cjihrig cjihrig mentioned this pull request Apr 14, 2017
Closed
3 tasks
jasnell pushed a commit that referenced this pull request Apr 17, 2017
@cjihrig @jasnell
doc: remove inspector experimental warning
a7286f6 
PR-URL: #12408
Ref: #12352
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@refack refack mentioned this pull request Apr 23, 2017
Closed
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
@cjihrig @evanlucas
doc: remove inspector experimental warning
651d615 
PR-URL: #12408
Ref: #12352
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request May 1, 2017
@cjihrig @evanlucas
doc: remove inspector experimental warning
768a1a0 
PR-URL: #12408
Ref: #12352
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@cjihrig @evanlucas
doc: remove inspector experimental warning
5a2d358 
PR-URL: #12408
Ref: #12352
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell mentioned this pull request May 11, 2017
Closed
@MylesBorins MylesBorins deleted the stable-inspect branch November 14, 2017 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aqrln aqrln aqrln approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@evanlucas evanlucas evanlucas approved these changes

@jasnell jasnell jasnell approved these changes

@eugeneo eugeneo eugeneo approved these changes

@ofrobots ofrobots ofrobots approved these changes

@joshgav joshgav Awaiting requested review from joshgav

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.