Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make accessors immune to context confusion #1238

Merged
merged 2 commits into from
Mar 23, 2015
Merged

src: make accessors immune to context confusion #1238

merged 2 commits into from
Mar 23, 2015

Commits on Mar 23, 2015

  1. src: make accessors immune to context confusion 

    It's possible for an accessor or named interceptor to get called with
a different execution context than the one it lives in, see the test
case for an example using the debug API.

This commit fortifies against that by passing the environment as a
data property instead of looking it up through the current context.

Fixes: nodejs#1190 (again)
PR-URL: nodejs#1238
Reviewed-By: Fedor Indutny <fedor@indutny.com>
    @bnoordhuis
    bnoordhuis committed Mar 23, 2015
    Configuration menu
    Copy the full SHA
    7e88a93 View commit details
    Browse the repository at this point in the history

  2. src: remove unnecessary environment lookups 

    Remove some unnecessary environment lookups and delete a few superfluous
HandleScope variables.

PR-URL: nodejs#1238
Reviewed-By: Fedor Indutny <fedor@indutny.com>
    @bnoordhuis
    bnoordhuis committed Mar 23, 2015
    Configuration menu
    Copy the full SHA
    2e5b87a View commit details
    Browse the repository at this point in the history