Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "benchmark: fix CLI arguments check in common.js" #12474

Closed
wants to merge 1 commit into from
Closed

Revert "benchmark: fix CLI arguments check in common.js" #12474

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Apr 17, 2017

Ugh. I goofed. I landed #12429, then realized it never went through CI and it breaks one of the tests in sequential.

This reverts commit e34f8e1.

Need to get this landed quickly so we unbreak CI

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, benchmark

@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Apr 17, 2017
@jasnell
Copy link
Member Author

jasnell commented Apr 17, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7460/

MylesBorins
MylesBorins approved these changes Apr 17, 2017
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubberstamp LGTM if it fixes CI

jasnell added a commit that referenced this pull request Apr 17, 2017
@jasnell
Revert "benchmark: fix CLI arguments check in common.js"
0227571 
This reverts commit e34f8e1.

PR-URL: #12474
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Apr 17, 2017

Landed.

@jasnell jasnell closed this Apr 17, 2017
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
@jasnell @evanlucas
Revert "benchmark: fix CLI arguments check in common.js"
14b4205 
This reverts commit e34f8e1.

PR-URL: #12474
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@evanlucas evanlucas mentioned this pull request May 1, 2017
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
@jasnell @evanlucas
Revert "benchmark: fix CLI arguments check in common.js"
443147d 
This reverts commit e34f8e1.

PR-URL: #12474
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@jasnell @evanlucas
Revert "benchmark: fix CLI arguments check in common.js"
440f4d4 
This reverts commit e34f8e1.

PR-URL: #12474
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@gibfahn
Copy link
Member

gibfahn commented May 16, 2017

dont-land-on-v6.x as it depends on #7094 (via #12429) which was semver-major.

@baby636 baby636 mentioned this pull request Jun 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasnell @gibfahn @MylesBorins @cjihrig @nodejs-github-bot