-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: unify quotes in an assert.md code example #12505
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
assert
Issues and PRs related to the assert subsystem.
doc
Issues and PRs related to the documentations.
labels
Apr 19, 2017
danbev
approved these changes
Apr 19, 2017
thefourtheye
approved these changes
Apr 19, 2017
jseijas
approved these changes
Apr 19, 2017
lpinca
approved these changes
Apr 19, 2017
benjamingr
approved these changes
Apr 19, 2017
DavidCai1111
approved these changes
Apr 19, 2017
DavidCai1111
approved these changes
Apr 19, 2017
cjihrig
approved these changes
Apr 19, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this needs to sit for 48 hours.
Landed in 211813c |
vsemozhetbyt
added a commit
that referenced
this pull request
Apr 19, 2017
PR-URL: #12505 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: David Cai <davidcai1993@yahoo.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
3 tasks
Fixes #11128 which is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc, assert