Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: correcting comment spelling #12528

Closed
wants to merge 1 commit into from
Closed

module: correcting comment spelling #12528

wants to merge 1 commit into from

Conversation

WORMSS
Copy link
Contributor

@WORMSS WORMSS commented Apr 20, 2017

A minor spelling mistake, no logic changes.

Checklist
  • documentation is changed or added
  • commit message follows [commit guidelines]
Affected core subsystem(s)

module (only comment)

@nodejs-github-bot nodejs-github-bot added the module Issues and PRs related to the module subsystem. label Apr 20, 2017
thefourtheye
thefourtheye reviewed Apr 20, 2017
View reviewed changes
lib/module.js Outdated
@@ -265,7 +265,7 @@ if (process.platform === 'win32') {
// The path segment separator check ('\' and '/') was used to get
// node_modules path for every path segment.
// Use colon as an extra condition since we can get node_modules
// path for dirver root like 'C:\node_modules' and don't need to
// path for drive root like 'C:\node_modules' and don't need to
// parse driver name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not exactly sure what this comment actually means, but shouldn't this also be drive then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went back and forth a few times on the meaning on the sentence. In the end I thought best to just correct the spelling mistake incase I was wrong. But I can change it to parse drive name if that is the consensus.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think it should be safe to correct this instance as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

mhdawson
mhdawson approved these changes Apr 20, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WORMSS
module: fix typo in comments
1ddbeec 
A minor typo in comments, no logic changes.
@WORMSS WORMSS force-pushed the patch-spelling-mistake branch from 37b057c to 1ddbeec Compare April 20, 2017 17:10
@whitlockjc
Copy link
Contributor

LGTM

jasnell pushed a commit that referenced this pull request Apr 24, 2017
@WORMSS @jasnell
lib: fix typo in comments in module.js
26047c3 
A minor typo in comments, no logic changes.

PR-URL: #12528
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>
@jasnell
Copy link
Member

jasnell commented Apr 24, 2017

landed in 26047c3

@jasnell jasnell closed this Apr 24, 2017
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
@WORMSS @evanlucas
lib: fix typo in comments in module.js
5c873a2 
A minor typo in comments, no logic changes.

PR-URL: #12528
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>
@evanlucas evanlucas mentioned this pull request May 1, 2017
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
@WORMSS @evanlucas
lib: fix typo in comments in module.js
95cbc4d 
A minor typo in comments, no logic changes.

PR-URL: #12528
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@WORMSS @evanlucas
lib: fix typo in comments in module.js
cbdf9a9 
A minor typo in comments, no logic changes.

PR-URL: #12528
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>
gibfahn pushed a commit that referenced this pull request May 16, 2017
@WORMSS @gibfahn
lib: fix typo in comments in module.js
4ab88a0 
A minor typo in comments, no logic changes.

PR-URL: #12528
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>
MylesBorins pushed a commit that referenced this pull request May 18, 2017
@WORMSS @MylesBorins
lib: fix typo in comments in module.js
6e6e63a 
A minor typo in comments, no logic changes.

PR-URL: #12528
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>
@MylesBorins MylesBorins mentioned this pull request May 23, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@WORMSS @andrew749
lib: fix typo in comments in module.js
2908645 
A minor typo in comments, no logic changes.

PR-URL: nodejs/node#12528
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscdex mscdex mscdex left review comments

@mhdawson mhdawson mhdawson approved these changes

@DavidCai1111 DavidCai1111 DavidCai1111 approved these changes

@jseijas jseijas jseijas approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.