Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: replace IsConstructCalls with lambda #12533

Closed
wants to merge 2 commits into from
Closed

src: replace IsConstructCalls with lambda #12533

wants to merge 2 commits into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Apr 20, 2017

I've added a deprecation notice as the functions are public, but not
sure if this is correct or the format of the deprecation notice.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@danbev
src: replace IsConstructCalls with lambda
7513d2c 
I've added a deprecation notice as the functions are public, but not
sure if this is correct or the format of the deprecation notice.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 20, 2017
@danbev
Copy link
Contributor Author

danbev commented Apr 20, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7548/

@bnoordhuis
Copy link
Member

I've added a deprecation notice as the functions are public

stream_base.h is not a public header file, don't let anyone tell you otherwise.

@danbev
Copy link
Contributor Author

danbev commented Apr 20, 2017

stream_base.h is not a public header file, don't let anyone tell you otherwise.

Oh perfect, I'll remove the functions instead. Thanks

@danbev
Copy link
Contributor Author

danbev commented Apr 20, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7549/

@addaleax addaleax added the lib / src Issues and PRs related to general changes in the lib or src directory. label Apr 20, 2017
danbev added a commit to danbev/node that referenced this pull request Apr 24, 2017
@danbev
src: replace IsConstructCalls with lambda
8eb7790 
I've added a deprecation notice as the functions are public, but not
sure if this is correct or the format of the deprecation notice.

PR-URL: nodejs#12533
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danbev
Copy link
Contributor Author

danbev commented Apr 24, 2017

Landed in 8eb7790

@danbev danbev closed this Apr 24, 2017
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
@danbev @evanlucas
src: replace IsConstructCalls with lambda
ca90b86 
I've added a deprecation notice as the functions are public, but not
sure if this is correct or the format of the deprecation notice.

PR-URL: #12533
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@evanlucas evanlucas mentioned this pull request May 1, 2017
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
@danbev @evanlucas
src: replace IsConstructCalls with lambda
d26039a 
I've added a deprecation notice as the functions are public, but not
sure if this is correct or the format of the deprecation notice.

PR-URL: #12533
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@danbev @evanlucas
src: replace IsConstructCalls with lambda
08951a1 
I've added a deprecation notice as the functions are public, but not
sure if this is correct or the format of the deprecation notice.

PR-URL: #12533
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@gibfahn gibfahn added baking-for-lts PRs that need to wait before landing in a LTS release. lts-watch-v6.x labels May 16, 2017
@gibfahn
Copy link
Member

gibfahn commented May 16, 2017

Should this land in v6.x?

@danbev danbev deleted the stream_base-lambda branch June 28, 2017 05:40
@MylesBorins MylesBorins removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@danbev @bnoordhuis @gibfahn @jasnell @addaleax @benjamingr @cjihrig @MylesBorins @nodejs-github-bot